lkml.org 
[lkml]   [2007]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] dma-mapping-broken.h: flesh-out DMA API stubs
    On Fri, Feb 23, 2007 at 08:57:41AM -0500, Kyle McMartin wrote:
    > On Fri, Feb 23, 2007 at 07:13:32AM +0100, Heiko Carstens wrote:
    > > How about this for telling that an architecture doesn't support DMA?
    > > At least we could get rid of dma-mapping-broken.h and don't need to
    > > compile some afterwards dead code.
    > >
    > > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
    >
    > This like a lot better of an idea than stubbing out things which should never
    > be built in the first place...

    My only thought was that the intent must have been to allow compilation of a driver
    that checks for DMA at runtime (via dma_supported). But, I guess dma_supported is intended
    as a platform-level check?

    If the DMA availability is at the arch level then such a driver could
    use (albeit ugly) compile flags to cover that situation...?

    Well, either way is fine with me.

    John
    --
    John W. Linville
    linville@tuxdriver.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-23 15:55    [W:0.029 / U:2.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site