lkml.org 
[lkml]   [2007]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 13/18] V4L: cx88: Fix lockup on suspend
    Greg KH wrote:
    > -stable review patch. If anyone has any objections, please let us know.
    >
    > ------------------
    > From: Robert Hancock <hancockr@shaw.ca>
    >
    > Suspending with the cx88xx module loaded causes the system to lock up
    > because the cx88_audio_thread kthread was missing a try_to_freeze()
    > call, which caused it to go into a tight loop and result in softlockup
    > when suspending. Fix that.
    >
    > (cherry picked from commit a96afb3e9428f2e7463344f12dbc85faf08e2e09)
    >
    > Signed-off-by: Robert Hancock <hancockr@shaw.ca>
    > Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
    > Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    >

    Please drop this one... I shouldn't have sent it to 2.6.18.y nor 2.6.19.y ... tree-mixup :-/

    Sorry about that...

    -Mike Krufky


    > ---
    > drivers/media/video/cx88/cx88-tvaudio.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > --- linux-2.6.18.7.orig/drivers/media/video/cx88/cx88-tvaudio.c
    > +++ linux-2.6.18.7/drivers/media/video/cx88/cx88-tvaudio.c
    > @@ -38,6 +38,7 @@
    > #include <linux/module.h>
    > #include <linux/moduleparam.h>
    > #include <linux/errno.h>
    > +#include <linux/freezer.h>
    > #include <linux/kernel.h>
    > #include <linux/slab.h>
    > #include <linux/mm.h>
    > @@ -979,6 +980,7 @@ int cx88_audio_thread(void *data)
    > msleep_interruptible(1000);
    > if (kthread_should_stop())
    > break;
    > + try_to_freeze();
    >
    > /* just monitor the audio status for now ... */
    > memset(&t, 0, sizeof(t));
    >
    > --

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-22 02:17    [W:0.024 / U:60.480 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site