lkml.org 
[lkml]   [2007]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/1] PXAFB: Support for backlight control
    From
    Date
    On Wed, 2007-02-21 at 15:53 +0100, Rodolfo Giometti wrote:
    > Backlight control support for the PXA fram buffer.
    >
    > Signed-off-by: Rodolfo Giometti <giometti@enneenne.com>
    >
    > ---
    >
    > Each platform should define the backlight properties in its own setup
    > file in "linux/arch/arm/mach-pxa/" as follow:
    >
    > static int pxafb_bl_get_brightness(struct backlight_device *bl_dev)
    > {
    > return read_the_backlight_brightness();
    > }
    >
    > static int pxafb_bl_update_status(struct backlight_device *bl_dev)
    > {
    > int perc, ret;
    >
    > if (bl_dev->props->power != FB_BLANK_UNBLANK ||
    > bl_dev->props->fb_blank != FB_BLANK_UNBLANK)
    > perc = 0;
    > else
    > perc = bl_dev->props->brightness;
    >
    > write_the_backlight_brightness(perc);
    >
    > return 0;
    > }
    >
    > static struct backlight_properties wwpc1100_backlight_props = {
    > .get_brightness = pxafb_bl_get_brightness,
    > .update_status = pxafb_bl_update_status,
    > .max_brightness = 100,
    > };
    >
    > and then seting up the fb info as follow:
    >
    > wwpc1100_pxafb_info.modes = &special_modes;
    > wwpc1100_pxafb_info.bl_props = &wwpc1100_backlight_props;
    > set_pxa_fb_info(&wwpc1100_pxafb_info);

    Reading through the patch its:

    1) Not against any mainline kernel
    2) Not against a recent kernel

    There were a number of backlight class changes just merged into mainline
    and you need to sync up any patch against them.

    As mentioned by others, there is no need to tie the backlight driver
    into the framebuffer any more. Have a look at
    drivers/video/backlight/corgi_bl.c for an example (its used by PXA
    devices).

    I have said elsewhere I will take patches to make corgi_bl a more
    generic driver (or maybe create a simple generic backlight driver) along
    the lines of what Paul mentioned.

    Regards,

    Richard


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-22 02:03    [W:0.023 / U:61.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site