Messages in this thread Patch in this message | | | Date | Tue, 20 Feb 2007 17:50:00 -0800 | From | Greg KH <> | Subject | [patch 04/18] SCSI: add missing cdb clearing in scsi_execute() |
| |
-stable review patch. If anyone has any objections, please let us know.
------------------ From: Tejun Heo <htejun@gmail.com>
Clear-garbage-after-CDB patch missed scsi_execute() and it causes some ODDs (HL-DT-ST DVD-RAM GSA-H30N) choke during SCSI scan. Note that this patch is only for -stable. There is another more reliable fix for this problem proposed for devel tree.
http://thread.gmane.org/gmane.linux.ide/14605/focus=14605
Signed-off-by: Tejun Heo <htejun@gmail.com> Cc: Jens Axboe <jens.axboe@oracle.com> Cc: Douglas Gilbert <dougg@torque.net> Signed-off-by: Chris Wright <chrisw@sous-sol.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/scsi/scsi_lib.c | 1 + 1 file changed, 1 insertion(+)
--- linux-2.6.18.7.orig/drivers/scsi/scsi_lib.c +++ linux-2.6.18.7/drivers/scsi/scsi_lib.c @@ -191,6 +191,7 @@ int scsi_execute(struct scsi_device *sde goto out; req->cmd_len = COMMAND_SIZE(cmd[0]); + memset(req->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */ memcpy(req->cmd, cmd, req->cmd_len); req->sense = sense; req->sense_len = 0; -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |