lkml.org 
[lkml]   [2007]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 09/21] x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
    -stable review patch.  If anyone has any objections, please let us know.

    ------------------

    Also PTRACE_OLDSETOPTIONS should be accepted, as done by kernel/ptrace.c and
    forced by binary compatibility. UML/32bit breaks because of this - since it is wise
    enough to use PTRACE_OLDSETOPTIONS to be binary compatible with 2.4 host
    kernels.

    Until 2.6.17 (commit f0f2d6536e3515b5b1b7ae97dc8f176860c8c2ce) we had:

    default:
    return sys_ptrace(request, pid, addr, data);

    Instead here we have:
    case PTRACE_GET_THREAD_AREA:
    case ...:
    return sys_ptrace(request, pid, addr, data);

    default:
    return -EINVAL;

    This change was a style change - when a case is added, it must be explicitly
    tested this way. In this case, not enough testing was done.

    Cc: Andi Kleen <ak@suse.de>
    Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86_64/ia32/ptrace32.c | 1 +
    1 file changed, 1 insertion(+)

    --- linux-2.6.19.4.orig/arch/x86_64/ia32/ptrace32.c
    +++ linux-2.6.19.4/arch/x86_64/ia32/ptrace32.c
    @@ -243,6 +243,7 @@ asmlinkage long sys32_ptrace(long reques
    case PTRACE_SINGLESTEP:
    case PTRACE_DETACH:
    case PTRACE_SYSCALL:
    + case PTRACE_OLDSETOPTIONS:
    case PTRACE_SETOPTIONS:
    case PTRACE_SET_THREAD_AREA:
    case PTRACE_GET_THREAD_AREA:
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-21 02:49    [W:0.022 / U:0.404 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site