lkml.org 
[lkml]   [2007]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 53/59] TCP: rare bad TCP checksum with 2.6.19
    -stable review patch.  If anyone has any objections, please let us know.
    ------------------

    From: Jarek Poplawski <jarkao2@o2.pl>

    The patch "Replace CHECKSUM_HW by CHECKSUM_PARTIAL/CHECKSUM_COMPLETE"
    changed to unconditional copying of ip_summed field from collapsed
    skb. This patch reverts this change.

    The majority of substantial work including heavy testing
    and diagnosing by: Michael Tokarev <mjt@tls.msk.ru>
    Possible reasons pointed by: Herbert Xu and Patrick McHardy.

    Signed-off-by: Jarek Poplawski <jarkao2@o2.pl>
    Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    ---
    net/ipv4/tcp_output.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- linux-2.6.19.2.orig/net/ipv4/tcp_output.c
    +++ linux-2.6.19.2/net/ipv4/tcp_output.c
    @@ -1590,7 +1590,8 @@ static void tcp_retrans_try_collapse(str

    memcpy(skb_put(skb, next_skb_size), next_skb->data, next_skb_size);

    - skb->ip_summed = next_skb->ip_summed;
    + if (next_skb->ip_summed == CHECKSUM_PARTIAL)
    + skb->ip_summed = CHECKSUM_PARTIAL;

    if (skb->ip_summed != CHECKSUM_PARTIAL)
    skb->csum = csum_block_add(skb->csum, next_skb->csum, skb_size);
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-03 03:51    [W:0.022 / U:0.928 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site