lkml.org 
[lkml]   [2007]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: epoll handling in the alpha port
On Thu, 1 Feb 2007 15:20:45 -0500 Mike Frysinger <vapier@gentoo.org> wrote:

> the alpha linux port differs from all others when it comes to the epoll
> functions in that it uses '__NR_sys_epoll_XXX' instead of '__NR_epoll_XXX' in
> the asm/unistd.h header ... the trouble with this is that glibc maps the
> function name directly to an __NR_ define, so when it maps
> like 'epoll_create', it expects '__NR_epoll_create' (which it gets with all
> other architectures)
>
> is there some obvious thing i'm missing here ? or is the attached patch OK ?
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> --- a/include/asm-alpha/unistd.h
> +++ b/include/asm-alpha/unistd.h
> @@ -342,9 +342,9 @@
> #define __NR_io_cancel 402
> #define __NR_exit_group 405
> #define __NR_lookup_dcookie 406
> -#define __NR_sys_epoll_create 407
> -#define __NR_sys_epoll_ctl 408
> -#define __NR_sys_epoll_wait 409
> +#define __NR_epoll_create 407
> +#define __NR_epoll_ctl 408
> +#define __NR_epoll_wait 409
> #define __NR_remap_file_pages 410
> #define __NR_set_tid_address 411
> #define __NR_restart_syscall 412

It might be to late to fix this - we risk breaking userspace which worked
around it.

It would be safer to add the correct definitions while leaving the old ones
in place.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-02 06:09    [W:0.404 / U:0.632 seconds]
©2003-2014 Jasper Spaans. Advertise on this site