lkml.org 
[lkml]   [2007]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    Afaics, noautorel work_struct buys nothing for "struct net_bridge_port".

    If del_nbp()->cancel_delayed_work(&p->carrier_check) fails, port_carrier_check
    may be called later anyway. So the reading of *work in port_carrier_check() is
    equally unsafe with or without this patch.

    Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

    --- WQ/net/bridge/br_if.c~1_bridge 2007-02-18 22:56:49.000000000 +0300
    +++ WQ/net/bridge/br_if.c 2007-02-18 23:06:15.000000000 +0300
    @@ -85,7 +85,6 @@ static void port_carrier_check(struct wo

    dev = container_of(work, struct net_bridge_port,
    carrier_check.work)->dev;
    - work_release(work);

    rtnl_lock();
    p = dev->br_port;
    @@ -282,7 +281,7 @@ static struct net_bridge_port *new_nbp(s
    p->port_no = index;
    br_init_port(p);
    p->state = BR_STATE_DISABLED;
    - INIT_DELAYED_WORK_NAR(&p->carrier_check, port_carrier_check);
    + INIT_DELAYED_WORK(&p->carrier_check, port_carrier_check);
    br_stp_port_timer_init(p);

    kobject_init(&p->kobj);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-18 22:47    [W:0.020 / U:30.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site