lkml.org 
[lkml]   [2007]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Subject: [PATCH 2.6.20 004/005] dmfe: Add support for suspend/resume
Hi!
>
> Hello , I am sorry that I missed some parts of coding style. I need to reread it :-)
>
> There is a updated patch :

It looks better.

> + /* Disable Interrupt */
> + outl (0, dev->base_addr + DCR7);
> + outl (inl(dev->base_addr + DCR5), dev->base_addr + DCR5);

I'd kill space after outl...

> + /* Free RX buffers */
> + dmfe_free_rxbuffer(db);
> +
> + /* Power down device*/

and add space before */.

Congratulation, you passed coding-style-police-check ;-).
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-17 23:55    [W:0.053 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site