Messages in this thread | | | Date | Sat, 17 Feb 2007 23:52:15 +0100 | From | Pavel Machek <> | Subject | Re: Subject: [PATCH 2.6.20 004/005] dmfe: Add support for suspend/resume |
| |
Hi! > > Hello , I am sorry that I missed some parts of coding style. I need to reread it :-) > > There is a updated patch :
It looks better.
> + /* Disable Interrupt */ > + outl (0, dev->base_addr + DCR7); > + outl (inl(dev->base_addr + DCR5), dev->base_addr + DCR5);
I'd kill space after outl...
> + /* Free RX buffers */ > + dmfe_free_rxbuffer(db); > + > + /* Power down device*/
and add space before */.
Congratulation, you passed coding-style-police-check ;-). Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |