Messages in this thread | | | Subject | Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with ibmebus | From | Benjamin Herrenschmidt <> | Date | Sun, 18 Feb 2007 08:56:39 +1100 |
| |
On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote: > ibmebus has a fake root device that's not associated with an ofdt node. > Filter out any such devices in of_device_uevent().
Doh ! You are creating an of_device with no attached device-node ? That is totally evil ! Why do you need that ?
Ben.
> > Signed-off-by: Joachim Fenkes <fenkes@de.ibm.com> > --- > > > of_device.c | 4 ++++ > 1 files changed, 4 insertions(+) > > > diff -urp a/arch/powerpc/kernel/of_device.c b/arch/powerpc/kernel/of_device.c > --- a/arch/powerpc/kernel/of_device.c 2007-02-17 16:36:32.116368480 +0100 > +++ b/arch/powerpc/kernel/of_device.c 2007-02-17 16:44:01.319366352 +0100 > @@ -180,6 +180,10 @@ int of_device_uevent(struct device *dev, > > ofdev = to_of_device(dev); > > + /* e.g. ibmebus has a fake root device w/o ofdt node -- filter that */ > + if (!ofdev->node) > + return -ENODEV; > + > if (add_uevent_var(envp, num_envp, &i, > buffer, buffer_size, &length, > "OF_NAME=%s", ofdev->node->name)) > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |