Messages in this thread | | | Date | Sat, 17 Feb 2007 15:22:30 -0500 | From | Jeff Garzik <> | Subject | Re: [patch 2/2] natsemi: Support Aculab E1/T1 PMXc cPCI carrier cards |
| |
Mark Brown wrote: > Aculab E1/T1 PMXc cPCI carrier card cards present a natsemi on the cPCI > bus with an oversized EEPROM using a direct MII<->MII connection with no > PHY. This patch adds a new device table entry supporting these cards. > > Signed-Off-By: Mark Brown <broonie@sirena.org.uk>
> @@ -811,7 +816,11 @@ > np->hands_off = 0; > np->intr_status = 0; > np->eeprom_size = natsemi_pci_info[chip_idx].eeprom_size; > - np->ignore_phy = 0; > + if (natsemi_pci_info[chip_idx].flags & NATSEMI_FLAG_IGNORE_PHY) { > + np->ignore_phy = 1; > + } else { > + np->ignore_phy = 0; > + }
I ACK the patch itself, but since you have to resend anyway, please kill the braces surrounding the above single-C-stmt lines.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |