lkml.org 
[lkml]   [2007]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/10] debugfs: Remove misleading comments.
    Date
    From: Cornelia Huck <cornelia.huck@de.ibm.com>

    Just mention which error will be returned if debugfs is disabled. Callers
    should be able to figure out themselves what they need to check.

    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    fs/debugfs/inode.c | 12 +++---------
    1 files changed, 3 insertions(+), 9 deletions(-)

    diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
    index 9c51a9f..7b324cf 100644
    --- a/fs/debugfs/inode.c
    +++ b/fs/debugfs/inode.c
    @@ -212,9 +212,7 @@ static int debugfs_create_by_name(const char *name, mode_t mode,
    * you are responsible here.) If an error occurs, %NULL will be returned.
    *
    * If debugfs is not enabled in the kernel, the value -%ENODEV will be
    - * returned. It is not wise to check for this value, but rather, check for
    - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling
    - * code.
    + * returned.
    */
    struct dentry *debugfs_create_file(const char *name, mode_t mode,
    struct dentry *parent, void *data,
    @@ -264,9 +262,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file);
    * you are responsible here.) If an error occurs, %NULL will be returned.
    *
    * If debugfs is not enabled in the kernel, the value -%ENODEV will be
    - * returned. It is not wise to check for this value, but rather, check for
    - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling
    - * code.
    + * returned.
    */
    struct dentry *debugfs_create_dir(const char *name, struct dentry *parent)
    {
    @@ -297,9 +293,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_dir);
    * returned.
    *
    * If debugfs is not enabled in the kernel, the value -%ENODEV will be
    - * returned. It is not wise to check for this value, but rather, check for
    - * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling
    - * code.
    + * returned.
    */
    struct dentry *debugfs_create_symlink(const char *name, struct dentry *parent,
    const char *target)
    --
    1.5.0
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-17 00:45    [W:0.022 / U:30.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site