lkml.org 
[lkml]   [2007]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
    On Tue, 13 Feb 2007 16:11:14 +0100 Arnd Bergmann wrote:

    > On Monday 12 February 2007 17:51, Andi Kleen wrote:
    > > setcc() in math-emu is written as a gcc extension statement expression
    > > macro that returns a value.  However, it's not used that way and it's not
    > > needed like that, so just make it a do-while non-extension macro so that we
    > > don't use an extension when it's not needed.
    > >
    >
    > The patch looks good but it doesn't match the description any more, since
    > you now use a function...

    Hi Arnd,
    Someone else had that same comment, so I sent a corrected patch
    (description change only) to that mail.

    Thanks,
    ---
    ~Randy
    *** Remember to use Documentation/SubmitChecklist when testing your code ***
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-02-13 17:17    [from the cache]
    ©2003-2011 Jasper Spaans. Advertise on this site