Messages in this thread | | | Date | Tue, 13 Feb 2007 13:55:49 +0100 | From | Patrick McHardy <> | Subject | Re: [PATCH 2.6.20 12/14] nfnetlink_log: possible NULL pointer dereference in nfulnl_recv_config() |
| |
Micha³ Miros³aw wrote: > Eliminate possible NULL pointer dereference in nfulnl_recv_config(). > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > > --- linux-2.6.20/net/netfilter/nfnetlink_log.c.10 2007-02-12 17:05:14.000000000 +0100 > +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 17:35:50.000000000 +0100 > @@ -853,6 +853,9 @@ nfulnl_recv_config(struct sock *ctnl, st > ret = -EINVAL; > break; > } > + > + if (!inst) > + goto out_null;
I think we should check that an instance is present before doing any changes any return an error if the user tries to change the configuration for a non-existant instance. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |