![]() | |||||||||||||
Messages in this thread |
On Wed, Feb 07, 2007 at 09:32:54AM +0100, Christoph Hellwig wrote: > On Wed, Feb 07, 2007 at 07:59:18AM +0000, Linux Kernel Mailing List wrote: > > [IA64] swiotlb abstraction (e.g. for Xen) > > > > Add abstraction so that the file can be used by environments other than IA64 > > and EM64T, namely for Xen.> > Tony, this code is more than ugly, and even further not needed for anything > we actually need. Can you please revert it.> > Some comments below in case we need justification.. > > If Jan actually had a goal with that except making the code utterly > unreadable he should try again with small patches that are well > explained and do one thing at a at time. (And cane be reviewed an > improved on if needed. As the topic says - the goal is to support Xen. But yes, I was afraid someone would claim this make the code look ugly. And no, I currently don't have ideas to address any of your comments without breaking functionality on Xen... Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2007-02-12 08:35 [from the cache] ©2003-2008 | |||||||||||||