lkml.org 
[lkml]   [2007]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH x86 for review III] [1/29] i386: avoid gcc extension
Hi,

On 12/02/07, Andi Kleen <ak@suse.de> wrote:
> setcc() in math-emu is written as a gcc extension statement expression
> macro that returns a value. However, it's not used that way and it's not
> needed like that, so just make it a do-while non-extension macro so that we
> don't use an extension when it's not needed.

This description ...

> -#define setcc(cc) ({ \
> - partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \
> - partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); })
> +static inline void setcc(int cc)
> +{
> + partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3);
> + partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3);
> +}

... seems to contradict the implementation. No "do-while" here.

I hope this helps,
Jochen
--
http://seehuhn.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-12 20:47    [W:0.114 / U:2.732 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site