lkml.org 
[lkml]   [2007]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] containers (V7): Generic container system abstracted from cpusets code
    On 2/12/07, Srivatsa Vaddagiri <vatsa@in.ibm.com> wrote:
    > On Mon, Feb 12, 2007 at 12:15:22AM -0800, menage@google.com wrote:
    > > +void container_fork(struct task_struct *child)
    > > +{
    > > + task_lock(current);
    >
    > Can't this be just rcu_read_lock()?
    >

    In this particular patch (which is an almost verbatim
    extraction/renaming of the generic bits of the cpusets code into
    container.c) it probably could - but the main patch that adds the
    container_group support would lose it since we use kref to refcount
    container_group objects, and hence they're freed when their refcount
    reaches zero. RCU is still fine for reading the container_group
    pointers, but it's no good for updating them, since by the time you
    update it it may no longer be your container_group structure, and may
    instead be about to be deleted as soon as the other thread's
    rcu_synchronize() completes.

    Paul
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-12 20:29    [W:0.021 / U:30.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site