Messages in this thread | | | Date | Mon, 12 Feb 2007 00:21:05 +0100 | From | Pavel Machek <> | Subject | Re: NAK new drivers without proper power management? |
| |
Hi!
> > > > define .suspend that will always return -ENOSYS (then people will know they > > > > have to unload the driver before the suspend). Similarly, if you aren't sure > > > > whether or not the device requires .suspend and .resume, define .suspend that > > > > will always return -ENOSYS." > > > > > > Sounds ok to me. Where should this text go? > > > Documentation/SubmittingDrivers ? > > > > And testing/submitting drivers, perhaps with additional text in that to > > make it clear we want suspend/resume support or good excuses > > > > "Please verify your driver correctly handles suspend and resume. If it > > does not your patch submission is likely to be suspended and only resume > > when the driver correctly handles this feature" > > Maybe make it explicit that testing should be done for both suspend to > ram and to disk, and with the following usage scenarios as > applicable?
Well, for many people s2ram does not work even today... so requiring them to test it is slightly draconian.
> - built in; > - modular, loaded while suspending but not loaded prior to resume from > disk;
These two should be equivalent.
> - modular, loaded while suspending and loaded prior to resume from disk;
Ok.. but I'm not sure how many people will actually test it _that_ thoroughly. "Try to test it" is good enough for a first version. When suspend is in better shape, we can ask for more.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |