lkml.org 
[lkml]   [2007]   [Feb]   [1]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    /
    DateFri, 2 Feb 2007 03:33:43 +0100
    FromAdrian Bunk <>
    SubjectRe: [2.6.20-rc6] pktcdvd doesn't work
    On Thu, Feb 01, 2007 at 06:21:47PM -0800, Andrew Morton wrote:
    > On Fri, 2 Feb 2007 00:07:52 +0100 Luca Tettamanti <kronos.it@gmail.com> wrote:
    > 
    > > Il Thu, Feb 01, 2007 at 12:30:44AM +0100, Adrian Bunk ha scritto: 
    > > > On Tue, Jan 30, 2007 at 08:53:19PM +0100, Luca Tettamanti wrote:
    > > > > Hi,
    > > > > pktcdvd on kernel 2.6.20-rc6 is not working as expected. Any file that
    > > > > is written to the device is lost after umount.
    > > > > I rarely use pktcdvd but at some point it used to work on my system.
    > > > > 
    > > > > This is what I'm doing:
    > > > > 
    > > > > root@dreamland:/tmp# cdrwtool -d /dev/scd0 -q
    > > > > using device /dev/scd0
    > > > > 1029KB internal buffer
    > > > > setting write speed to 12x
    > > > > Settings for /dev/scd0:
    > > > >         Fixed packets, size 32
    > > > >         Mode-2 disc
    > > > >...
    > > > 
    > > > Does 2.6.20-rc7 work?
    > > > If no, does it work after applying the attached patch?
    > > > If no, does 2.6.19.2 work?
    > > 
    > > Git current + the following patch works.
    > > 
    > > > diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
    > > > index 6246219..7c95c76 100644
    > > > --- a/drivers/block/pktcdvd.c
    > > > +++ b/drivers/block/pktcdvd.c
    > > > @@ -765,34 +765,47 @@ static inline struct bio *pkt_get_list_first(struct bio **list_head, struct bio
    > > >   */
    > > >  static int pkt_generic_packet(struct pktcdvd_device *pd, struct packet_command *cgc)
    > > >  {
    > > > -	request_queue_t *q = bdev_get_queue(pd->bdev);
    > > > +	char sense[SCSI_SENSE_BUFFERSIZE];
    > 
    > Where did this patch come from?
    
    It's a revert of the commits 3b00315799d78f76531b71435fbc2643cd71ae4c 
    and 406c9b605cbc45151c03ac9a3f95e9acf050808c
    
    cu
    Adrian
    
    -- 
    
           "Is there not promise of rain?" Ling Tan asked suddenly out
            of the darkness. There had been need of rain for many days.
           "Only a promise," Lao Er said.
                                           Pearl S. Buck - Dragon Seed
    
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2007-02-02 03:37    [from the cache]
    ©2003-2008