lkml.org 
[lkml]   [2007]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] CELL PPU Oprofile cleanup patch
From
Date
Mikey:

Yes, that is an error. Thanks for the catch.

Carl Love

On Fri, 2007-02-02 at 09:52 +1100, Michael Neuling wrote:
> Carl,
>
> > +#define NUM_TRACE_BUS_WORDS 4
> > +#define NUM_INPUT_BUS_WORDS 2
>
> <snip>
>
> > - for (i = 0; i < 4; i++)
> > + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> > trace_bus[i] = 0xff;
> >
> > - for (i = 0; i < 2; i++)
> > + for (i = 0; i < NUM_INPUT_BUS_WORDS; i++)
> > input_bus[i] = 0xff;
>
> The first loop looks like a bug... Shouldn't it be
> NUM_TRACE_BUS_WORDS?
>
> Mikey

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-02 00:19    [W:0.105 / U:1.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site