Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [patch 8/9] Add time_update_mt_guess() | Date | Thu, 1 Feb 2007 12:28:50 +0100 |
| |
On Thursday 01 February 2007 11:00, jbohac@suse.cz wrote:
> Index: linux-2.6.20-rc5/arch/x86_64/kernel/apic.c > =================================================================== > --- linux-2.6.20-rc5.orig/arch/x86_64/kernel/apic.c > +++ linux-2.6.20-rc5/arch/x86_64/kernel/apic.c > @@ -63,6 +63,9 @@ int using_apic_timer __read_mostly = 0; > > static void apic_pm_activate(void); > > +extern void time_update_mt_guess(void);
No externs in .c files
> +inline u64 mt_to_nsec(u64 mt) > +{ > + u64 ret; > + ret = ((mt & 0xffffff) * vxtime.mt_q) >> 32; > + mt >>= 24; > + ret += ((mt & 0xffffff) * vxtime.mt_q) >> 8; > + mt >>= 24; > + ret += ( mt * vxtime.mt_q) << 16; > + return ret;
Why so complicated? Isn't a single multiply good enough?
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |