Messages in this thread | | | Date | Sat, 8 Dec 2007 22:58:11 +0100 | From | Adrian Bunk <> | Subject | Re: Correct types for mod_devicetable.h (was: Re: m68k build failure) |
| |
On Mon, Dec 03, 2007 at 09:02:19PM +1100, Rusty Russell wrote: > On Sunday 02 December 2007 22:22:31 Geert Uytterhoeven wrote: > > On Sat, 1 Dec 2007, Pierre Ossman wrote: > > > Yeah, that could work. Have a header with stuff like this: > > > > > > typedef u16 __attribute__((aligned(2))) aligned_u16; > > > typedef u32 __attribute__((aligned(4))) aligned_u32; > > > > I gave it a try: > > This seems to turn a molehill into a mountain. > > We can change that mod_devicetable.h at any time; it's not supposed to be a > userspace API (the kernel build system doesn't count).
module-init-tools is userspace and not shipped as part of the kernel build system...
> So, just insert two bits of padding in sdio_device_id and insert a comment > saying "/* Explicit padding: works even if we're cross-compiling */".
We had one such problem in 2.6.23 and now we had a similar one in 2.6.24.
Getting the alignment issues automatically right would really be an improvement...
> Thanks, > Rusty.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |