Messages in this thread |  | | | Date | Sat, 8 Dec 2007 09:47:49 -0800 (PST) | | From | Linus Torvalds <> | | Subject | Re: tipc_init(), WARNING: at arch/x86/mm/highmem_32.c:52, [2.6.24-rc4-git5: Reported regressions from 2.6.23] | |
On Sat, 8 Dec 2007, Matt Mackall wrote:
>
> Avoid calling page allocator with __GFP_ZERO, as we might be in atomic
> context and this will make thing unhappy on highmem systems. Instead,
> manually zero allocations from the page allocator.
I think this is fine, but didn't we fix the warning already? Calling page
allocators with __GFP_ZERO should be fine, as long as __GFP_HIGHMEM isn't
set, and slab/slub/slob/kmalloc cannot use GFP_HIGHMEM *anyway*.
But I'll apply it anyway, because it looks "obviously correct" from the
standpoint that the _other_ |  |