lkml.org 
[lkml]   [2007]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scheduler: fix x86 regression in native_sched_clock

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > > A bit risky - it's quite an expansion of code which no longer can
> > > call printk.
> > >
> > > You might want to take that WARN_ON out of __update_rq_clock() ;)
> >
> > hm, dont we already detect printk recursions and turn them into a
> > silent return instead of a hang/crash?
>
> We'll pop the locks and will proceed to do the nested printk. So
> __update_rq_clock() will need rather a lot of stack ;)

yeah. That behavior of printk is rather fragile. I think my previous
patch should handle all such incidents.

Ingo


\
 
 \ /
  Last update: 2007-12-07 12:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site