lkml.org 
[lkml]   [2007]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scheduler: fix x86 regression in native_sched_clock

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > - t = printk_clock();
> > + t = cpu_clock(printk_cpu);
> > nanosec_rem = do_div(t, 1000000000);
> > tlen = sprintf(tbuf,
> > "<%c>[%5lu.%06lu] ",
>
> A bit risky - it's quite an expansion of code which no longer can call
> printk.
>
> You might want to take that WARN_ON out of __update_rq_clock() ;)

hm, dont we already detect printk recursions and turn them into a silent
return instead of a hang/crash?

Ingo


\
 
 \ /
  Last update: 2007-12-07 11:43    [from the cache]
©2003-2011 Jasper Spaans