lkml.org 
[lkml]   [2007]   [Dec]   [6]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 06 Dec 2007 09:43:27 +0100
FromCarsten Otte <>
SubjectRe: [patch] ext2: xip check fix
Nick Piggin wrote:
>> Xip does only work, if both do match PAGE_SIZE because it 
>> does'nt support multiple calls to direct_access in the get_xip_page 
>> address space operation. Thus we check both here, actually this was 
>> changed from how it looks after your patch as a bugfix where our 
>> tester tried a 4k filesystem on a 2k blockdev.
>> Did I miss something?
> 
> However, the bdev block size may be changed with sb_set_blocksize. It
> doesn't actually have to match the hardware sector size -- if this
> does matter for XIP, then I think you need some other check here.
Hmmmmhh. For a bdev with PAGE_SIZE hardsect size, there is no other 
valid value then PAGE_SIZE that one could set it to. Or can it indeed 
be changed to a value greater then PAGE_SIZE or smaller then hardsect 
size?



\
 
 \ /
  Last update: 2007-12-06 10:27    [from the cache]
©2003-2008