lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 05 Dec 2007 18:18:47 -0800
FromRandy Dunlap <>
SubjectRe: [PATCH] Reduce stack used by lib/hexdump.c
Joe Perches wrote:
> On Wed, 2007-12-05 at 16:01 -0800, Andrew Morton wrote:
>> You could trim linebuf[] to 80 chars or so.  Extra points for making it
>> very clear when someone tries to exceed that - strcpy(linebuf, "stop being
>> stupid").
> 
> Maybe just eliminate the 16 or 32 byte width option and
> force it to only 16 byte widths.
> 
> That'd keep it down to ~ 100 bytes nicely.
> 
> Prefix + address + dump + ascii: 20 + 18 + 48 + 10.

Have you checked users (callers)?  I'm pretty sure that one of the
callers wanted 32 and that's why it's there.


-- 
~Randy
Features and documentation: http://lwn.net/Articles/260136/


\
 
 \ /
  Last update: 2007-12-06 03:23    [from the cache]
©2003-2008