lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 12/18] usb: mon nopage
On Wed, Dec 05, 2007 at 08:39:25AM -0800, Pete Zaitcev wrote:
> On Wed, 05 Dec 2007 18:15:59 +1100, npiggin@suse.de wrote:
>
> > Convert USB mon driver from nopage to fault.
>
> > if (offset >= rp->b_size)
> > - return NOPAGE_SIGBUS;
> > + return VM_FAULT_SIGBUS;
> > chunk_idx = offset / CHUNK_SIZE;
> > pageptr = rp->b_vec[chunk_idx].pg;
> > get_page(pageptr);
> > - if (type)
> > - *type = VM_FAULT_MINOR;
> > - return pageptr;
> > + vmf->page = pageptr;
> > + return 0;
>
> Looks like a trivial change, I ack this. It's a rarely used API, I have
> to run tests to see how it works. I'll collect any failing pieces later
> if any.

That would be great, thanks.


> Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
>
> -- Pete


\
 
 \ /
  Last update: 2007-12-06 00:57    [W:0.090 / U:0.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site