lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Is BIO_RW_FAILFAST really usable?
On Tuesday December 4, jens.axboe@oracle.com wrote:
>
> Hrmpf. It looks like the SCSI layer is a little too trigger happy. Any
> chance you could try and trace where this happens?

in scsi_lib.c, in scsi_request_fn, near the top of the main
while (!blk_queue_plugged(q)) {
loop:

if (!scsi_dev_queue_ready(q, sdev)) {
if ((req->cmd_flags & REQ_FAILFAST) &&
!(req->cmd_flags & REQ_PREEMPT)) {
scsi_kill_request(req, q);
continue;
}
break;
}

If I remove the "if failfast and not preempt then kill" logic, my
problem goes away.

NeilBrown


\
 
 \ /
  Last update: 2007-12-06 00:17    [W:0.046 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site