Messages in this thread | | | Date | Wed, 05 Dec 2007 16:33:38 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH] depmod: sort output according to modules.order |
| |
Sam Ravnborg wrote: > Hi Tejun. > On Tue, Dec 04, 2007 at 10:55:48PM +0900, Tejun Heo wrote: >> Kbuild now generates and installs modules.order along with modules. >> This patch updates depmod such that it sorts module list according to >> the file before generating output files. Modules which aren't on >> modules.order are put after modules which are ordered by >> modules.order. >> >> This makes modprobe to prioritize modules according to kernel >> Makefile's just as built-in modules are link-ordered by them. > > With this change depmod require the precense of modules.order. > Could we make it optional so depmod are backward compatible?
It is backward compatible by virtue of
+ if (errno == ENOENT) + return;
in sort_modules(). If the file isn't there, the list isn't sorted.
> It would also simplify the kbuild integration if depmod > could read the modules as a space separated list where > duplicates are allowed. > If we do so then the is no reason to escape to the shell > in Makeilfe.build and we do not have to remove duplicates either.
I'm no Makefile expert so no doubt my modifications are ugly. But I think producing a file w/ duplicates in it is just ugly.
-- tejun
| |