Messages in this thread |  | | | Date | Wed, 05 Dec 2007 15:22:17 +0800 | | From | Li Zefan <> | | Subject | Re: [PATCH] kbuild: implement modules.order |
Tejun Heo wrote:
> WANG Cong wrote:
>>>> I think, you forgot to free(3) the memory you calloc(3)'ed and
>>>> malloc(3)'ed above.
>>> It's a simple program where whole body is in main(). Why bother?
>>> What's the benefit of adding hash-table iterating free logic?
>>>
>> Personally, I think memory leaks are bugs. And we hate bugs. ;)
>
> Trust me. As a person buried alive in bug reports, I hate bugs too. I
> just don't agree that this type of programs should free all its
> resources before exiting. How about adding a comment saying /* we're
> going out anyway, don't bother freeing hashtable */?
>
I don't consider this as memory leak. I agree that a comment should be
enough. :)
Li Zefam
|  |