Messages in this thread |  | | | Date | Wed, 5 Dec 2007 08:34:23 -0800 | | From | Pete Zaitcev <> | | Subject | Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220 |
On Fri, 30 Nov 2007 16:30:11 +0000, Jaime Velasco Juan <jsagarribay@gmail.com> wrote:> --- a/drivers/usb/serial/option.c> +++ b/drivers/usb/serial/option.c> - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) },
> - { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) },
> + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) },
> + { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS, 0xff, 0xff, 0xff) },
Looks good to me, shorter than my patch, has no duplication, allows to
use the storage, looks like a winner. Unfortunately, it leaves ub for dead,
because ub cannot invoke the necessary initializer unless we move it to
libusual. But oh well, I'll think about it.
Took me this long to test because I had to ask kind people in England
to replug the modem.
Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
-- Pete
|  |