lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateWed, 05 Dec 2007 14:15:35 +0100
FromStefan Richter <>
SubjectRe: [patch 06/18] ieee1394: nopage
> npiggin@suse.de wrote:
>> @@ -275,7 +270,7 @@ int dma_region_mmap(struct dma_region *d
>>  	if (!dma->kvirt)
>>  		return -EINVAL;
>> 
>> -	/* must be page-aligned */
>> +	/* must be page-aligned (XXX: comment is wrong, we could allow pgoff) */
>>  	if (vma->vm_pgoff != 0)
>>  		return -EINVAL;
>> 
> 
> Are you sure that the comment is wrong?  Could it be that there are
> assumptions elsewhere which require page alignment?  (I should be able
> to answer that, but I'm not.)

PS:  Assumed the comment is wrong, is the code wrong then too?
-- 
Stefan Richter
-=====-=-=== ==-- --=-=
http://arcgraph.de/sr/

\
 
 \ /
  Last update: 2007-12-05 14:19    [from the cache]
©2003-2008