lkml.org 
[lkml]   [2007]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.24-rc4-mm1: kobj changes fallout on powerpc
    On Wed, Dec 05, 2007 at 03:15:15AM -0600, Olof Johansson wrote:
    > powerpc allyesconfig fails on the following two drivers (iseries_defconfig
    > fails for the veth one):
    >
    > drivers/net/ehea/ehea_main.c: In function 'ehea_driver_sysfs_add':
    > drivers/net/ehea/ehea_main.c:2812: error: 'struct device_driver' has no member named 'kobj'
    > drivers/net/ehea/ehea_main.c:2815: error: 'struct device_driver' has no member named 'kobj'
    > drivers/net/ehea/ehea_main.c:2818: error: 'struct device_driver' has no member named 'kobj'
    > drivers/net/ehea/ehea_main.c: In function 'ehea_driver_sysfs_remove':
    > drivers/net/ehea/ehea_main.c:2830: error: 'struct device_driver' has no member named 'kobj'
    > drivers/net/iseries_veth.c: In function 'veth_module_init':
    > drivers/net/iseries_veth.c:1714: error: 'struct device_driver' has no member named 'kobj'
    >
    > I'm guessing it's some of Greg's kobj/driver patches that missed to
    > change this, but it's not obvious to me how it should be fixed.
    >
    >
    > -Olof
    Hi,

    Probably this patch should fix the build failure (The kobject related
    structure have been moved to driver_private struct).

    Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
    --
    --- linux-2.6.24-rc4/drivers/net/ehea/ehea_main.c 2007-12-04 09:56:10.000000000 +0530
    +++ linux-2.6.24-rc4/drivers/net/ehea/~ehea_main.c 2007-12-05 18:01:31.000000000 +0530
    @@ -2809,7 +2809,7 @@ static int ehea_driver_sysfs_add(struct
    {
    int ret;

    - ret = sysfs_create_link(&driver->kobj, &dev->kobj,
    + ret = sysfs_create_link(&driver->driver_private->kobj, &dev->kobj,
    kobject_name(&dev->kobj));
    if (ret == 0) {
    ret = sysfs_create_link(&dev->kobj, &driver->kobj,

    \
     
     \ /
      Last update: 2007-12-05 14:15    [W:0.035 / U:30.464 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site