Messages in this thread | | | Date | Tue, 4 Dec 2007 13:26:49 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] i386 IOAPIC: de-fang IRQ compression |
| |
* Len Brown <lenb@kernel.org> wrote:
> So while the irq compression code on i386 should really > be deleted -- even before merging the x86_64 irq-overhaul, > this patch simply disables it on all high volume systems > to avoid problems #1 and #2 on most all i386 systems. > > A large system with pin numbers >=64 will still have compression > to conserve limited IRQ numbers for sparse IOAPICS. However, > the vast majority of the planet, those with only pin numbers < 64 > will use an identity GSI -> IRQ mapping. > > Signed-off-by: Len Brown <len.brown@intel.com>
thanks for the patch and the extensive description. I've applied this to x86.git. Do you agree that this has no urgency for v2.6.24 and is thus v2.6.25 material?
would you be interested in doing a follow-up patch as well that just yanks all of the irq compression code? That would keep things nicely bisectable and testable - the second, larger patch would be a NOP in theory on most systems.
Ingo
| |