[lkml]   [2007]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Avoid overflows in kernel/time.c
    On Thu, 29 Nov 2007 16:19:51 -0800 "H. Peter Anvin" <> wrote:

    > When the conversion factor between jiffies and milli- or microseconds
    > is not a single multiply or divide, as for the case of HZ == 300, we
    > currently do a multiply followed by a divide. The intervening
    > result, however, is subject to overflows, especially since the
    > fraction is not simplified (for HZ == 300, we multiply by 300 and
    > divide by 1000).
    > This is exposed to the user when passing a large timeout to poll(),
    > for example.
    > This patch replaces the multiply-divide with a reciprocal
    > multiplication on 32-bit platforms. When the input is an unsigned
    > long, there is no portable way to do this on 64-bit platforms there is
    > no portable way to do this since it requires a 128-bit intermediate
    > result (which gcc does support on 64-bit platforms but may generate
    > libgcc calls, e.g. on 64-bit s390), but since the output is a 32-bit
    > integer in the cases affected, just simplify the multiply-divide
    > (*3/10 instead of *300/1000).
    > The reciprocal multiply used can have off-by-one errors in the upper
    > half of the valid output range. This could be avoided at the expense
    > of having to deal with a potential 65-bit intermediate result. Since
    > the intent is to avoid overflow problems and most of the other time
    > conversions are only semiexact, the off-by-one errors were considered
    > an acceptable tradeoff.
    > NOTE: This patch uses a bc(1) script to compute the appropriate
    > constants.

    My ia64 allmodconfig build has taken

    akpm 15700 89.6 0.0 8256 700 pts/4 RN+ 03:09 10:41 bc -q kernel/timeconst.bc

    11 minutes so far. fc6/x86_64.

     \ /
      Last update: 2007-12-04 12:33    [W:0.024 / U:35.532 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site