lkml.org 
[lkml]   [2007]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix for futex_wait signal stack corruption


    On Tue, 4 Dec 2007, Steven Rostedt wrote:
    >
    > Since arg3 is out, which do you prefer? Creating an arg4 (and perhaps
    > more) in the block or having a u64 arg? Changing all the args to u64 may
    > be the best.

    I suspect that the best option is probably to make that thing a unnamed
    union of the actual different types the different restart cases needs,
    which also allows you to name things appropriately and not have any wasted
    space.

    Leave the arg0-3 ones around as one of the unions, both to avoid having to
    change other things and to have a "generic" one for stuff that simply
    doesn't much care (in order to not have tons and tons of substructures to
    the union when most users really don't need any fancy types).

    I think we already depend on recent-enough gcc's that unnamed unions are
    ok and we don't need to play games with naming.

    Linus


    \
     
     \ /
      Last update: 2007-12-05 02:49    [W:0.023 / U:0.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site