lkml.org 
[lkml]   [2007]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix for futex_wait signal stack corruption


On Tue, 4 Dec 2007, Steven Rostedt wrote:
>
> The solution I did to solve this is to allocate a temporary buffer when
> setting up the block and free it in futex_wait_restart. This patch
> allows David's test program to actually pass.

No. Unacceptable. This is a memory leak in case nobody retries it. It's
basically not how you can do this thing.

The *only* thing you can pass for a system call restart is the argument
block register state. If that is not enough, then you cannot restart it.
It's that simple.

Andrew, please do *not* put this in any queues. It's fundamentally broken,
and cannot be fixed as is.

Linus


\
 
 \ /
  Last update: 2007-12-04 22:21    [from the cache]
©2003-2011 Jasper Spaans. Advertise on this site