Messages in this thread | | | Date | Tue, 1 Jan 2008 01:49:59 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] sh: sh7712 clock support |
| |
On Mon, Dec 31, 2007 at 04:32:25PM -0000, Andrew Murray wrote: > +static void bus_clk_init(struct clk *clk) > +{ > + clk->rate = CONFIG_SH_PCLK_FREQ; > +} > + > +static struct clk_ops sh7712_bus_clk_ops = { > + .init = bus_clk_init, > +}; > + This shouldn't be necessary, the bus clk already references the master clk as its parent, and inherits the rate from there. If you have no recalc work to do, then you should be able to just leave this out altogether. If you actually need this dummy init, then something is broken with the upper layer, which we should fix ;-)
Patch looks fine otherwise. Tidy this up and I'll apply it.
| |