Messages in this thread | | | Date | Sun, 30 Dec 2007 14:23:37 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: kprobes remove fix_riprel #ifdef |
| |
* Masami Hiramatsu <mhiramat@redhat.com> wrote:
> Hello Harvey, > > A similar idea was already nack-ed by Ananth. > http://sources.redhat.com/ml/systemtap/2007-q4/msg00468.html > And I agree his thought. > > Especially, "riprel" does not exist on x86_32, so fix_riprel() > is meaningless on it. > Thus, I think it would better be ifdef'd in call-site.
but we regularly do this in generic code: we add calls that are NOPs on some architectures. For example flush_cache_page() makes no sense on the x86 architecture. So i'm inclined to apply Harvey's cleanup - less #ifdef complexity in higher-level code is very much favored, even if "riprel" is a NOP concept on 32-bit.
Ingo
| |