lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Introduce REX prefix helper for kprobes

* Masami Hiramatsu <mhiramat@redhat.com> wrote:

> > Why is a macro better than an inline, and why the odd mIXed case?
>
> I thought we can use macro because it just check a bit mask. And if we
> use this as a macro, it will be defined in #ifdef block at the top of
> kprobes.c. It is simple in this case. I know the inline is better than
> the macro, it can check the type of arguments. If you would like to
> use inline, how about this?

yes, we prefer inlines for just about everything. We have reoccuring
regressions due to macro side-effects, lack of type and argument
checking - and the simplest maintenance policy is to just never
introduce new macros. Macros also played an active role in creating our
current include file dependencies spaghetti. So unless there are very,
very strong reasons in favor of adding a macro, please always use
inlines.

Ingo


\
 
 \ /
  Last update: 2007-12-30 14:31    [W:2.001 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site