lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] AMD Thermal Interrupt Support
    From
    Date
    "Russell Leidich" <rml@google.com> writes:

    Not sure you have addressed any of my feedback; don't see many changes.

    When you repost stuff can you please add a changelog or if you decide
    to not address some review comment say why at least.

    Also the patch changelog description is missing anyways?

    Biggest issue I raised is still not addressed:

    > + /*
    > + * If any of the northbridges has PCI ID 0x1103, then its thermal
    > + * hardware suffers from an erratum which prevents this code from
    > + * working, so abort.
    > + */
    > + for (nb_num = 0; nb_num < num_k8_northbridges; nb_num++) {
    > + if ((k8_northbridges[nb_num]->device) == 0x1103)
    > + goto out;
    > + }

    AFAIK that's all K8s so the code will never work on them.

    -Andi


    \
     
     \ /
      Last update: 2007-12-30 19:43    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean