lkml.org 
[lkml]   [2007]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH - RFC] x86: unify arch/x86/kernel/Makefile(s)

* Sam Ravnborg <sam@ravnborg.org> wrote:

> Combine the 32 and 64 bit specific Makefiles in one file. While doing
> so link order was (almost) preserved on 32 bit but on 64 bit link
> order changed a lot.
>
> Patch was checked with defconfig + allyesconfig builds. The same .o
> files were linked in these configurations.
>
> To keep readability of the Makefiles a few Kconfig symbols was
> added/modified and it was checked that they were not used anywhere
> else.

hm, i agree with this change, but would it be possible to split this up
into gradual steps, to change the rules on 64-bit one by one? That would
make it much more bisectable. In our experience changes to the link
order have a high likelyhood of breaking stuff, as we've got so many
implicit initcall dependencies that are not explicitly spelled out.

Ingo


\
 
 \ /
  Last update: 2007-12-30 15:59    [W:0.475 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site