Messages in this thread | | | Date | Tue, 4 Dec 2007 14:57:55 +1100 | From | Herbert Xu <> | Subject | Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode |
| |
On Tue, Dec 04, 2007 at 11:50:55AM +0800, Wang Chen wrote: > > > #include <linux/cache.h> > > #include <linux/snmp.h> > > +#include <linux/smp.h> > > It's no need to include smp.h?
We need it for smp_processor_id. Well we needed it before too but there's probably some implicit inclusion which has made it work. It's better to declare these inclusions explicitly as otherwise they may break on less common architectures later.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |