Messages in this thread | | | Date | Mon, 3 Dec 2007 18:24:28 -0500 | From | "Ed L. Cashin" <> | Subject | Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da) |
| |
On Mon, Dec 03, 2007 at 02:47:22PM -0800, Andrew Morton wrote: > On Mon, 3 Dec 2007 16:38:37 -0500 > "Ed L. Cashin" <ecashin@coraid.com> wrote: ... > > It appears that the fbc->counters pointer is NULL. > > Does this fix? > > --- a/drivers/block/aoe/aoeblk.c~a > +++ a/drivers/block/aoe/aoeblk.c > @@ -6,6 +6,7 @@ > > #include <linux/hdreg.h> > #include <linux/blkdev.h> > +#include <linux/backing-dev.h> > #include <linux/fs.h> > #include <linux/ioctl.h> > #include <linux/genhd.h> > @@ -228,6 +229,7 @@ aoeblk_gdalloc(void *vp) > > spin_lock_irqsave(&d->lock, flags); > blk_queue_make_request(&d->blkq, aoeblk_make_request); > + bdi_init(&d->blkq.backing_dev_info); > gd->major = AOE_MAJOR; > gd->first_minor = d->sysminor * AOE_PARTITIONS; > gd->fops = &aoe_bdops; > _ > > > <wonders whether blk_queue_make_request() should be running bdi_init()?>
No, the behavior doesn't change with this patch applied.
Meanwhile I have started a git bisect, and hopefully that will turn up a specific patch before I hit an unbootable kernel or get my machine in a state where it won't boot.
-- Ed L Cashin <ecashin@coraid.com>
| |