Messages in this thread |  | | | Date | Mon, 3 Dec 2007 15:09:05 +0000 | | From | Christoph Hellwig <> | | Subject | Re: [PATCH] xfs: revert to double-buffering readdir | |
On Fri, Nov 30, 2007 at 06:22:09PM +1100, Timothy Shimmin wrote:
> Hmmm, don't see the point of "eof" local var now.
> Previously bhv_vop_readdir() returned eof.
> I presume if we don't move the offset (offset == startoffset) then
> we're done and break out?
> So we lost eof when going to the filldir in the getdents code etc...
Yes, it's just copy & paste. We can trivially kill the variable.
|  |