lkml.org 
[lkml]   [2007]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/12] pci : Use mutex instead of semaphore in driver core
On Dec 29, 2007 10:55 AM, Matthew Wilcox <matthew@wil.cx> wrote:
> On Sat, Dec 29, 2007 at 09:10:57AM +0800, Dave Young wrote:
> > @@ -207,9 +207,9 @@ void pci_walk_bus(struct pci_bus *top, v
> > next = dev->bus_list.next;
> >
> > /* Run device routines with the device locked */
> > - down(&dev->dev.sem);
> > + mutex_lock(&dev->dev.mutex);
> > cb(dev, userdata);
> > - up(&dev->dev.sem);
> > + mutex_unlock(&dev->dev.mutex);
> > }
> > up_read(&pci_bus_sem);
> > }
>
> Patches should be self-contained for ease of bisecting. I can't tell
> whether this patch is correct or not because you haven't included all
> the other places that need to change at the same time as this.

Hi,

I will repost them after some fixes.

>
> --
> Intel are signing my paycheques ... these opinions are still mine
> "Bill, look, we understand that you're interested in selling us this
> operating system, but compare it to ours. We can't possibly take such
> a retrograde step."
>


\
 
 \ /
  Last update: 2007-12-29 06:11    [W:0.064 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site