Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] AMD Thermal Interrupt Support | Date | Sat, 29 Dec 2007 03:34:34 +0100 |
| |
On Saturday 29 December 2007 03:30:17 Valdis.Kletnieks@vt.edu wrote: > On Sat, 29 Dec 2007 03:11:51 +0100, Andi Kleen said: > > On Friday 28 December 2007 21:40:28 Russell Leidich wrote: > > > + printk(KERN_CRIT "CPU 0x%x: Thermal monitoring not " > > + "functional.\n", cpu); > > > > Why is that KERN_CRIT? Does not seem that critical to me. > > If you think you're running on a chipset that *should* support thermal > monitoring, and it isn't there in a usable state, that seems pretty critical > to me. If that didn't work, you probably can't trust the "oh, the chip will > thermal-limit itself if it gets to 100C or whatever" either.
Thermal shutdown in emergency uses quite different mechanisms (e.g. it goes directly through pins to the motherboard); i don't think that code checks for that.
-Andi
| |