lkml.org 
[lkml]   [2007]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/30] Unionfs: remove unnecessary lock when deleting whiteouts
    Date
    Lockdep complained, because we eventually call vfs_unlink which'd grab the
    necessary locks.

    Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
    ---
    fs/unionfs/dirhelper.c | 2 --
    1 files changed, 0 insertions(+), 2 deletions(-)

    diff --git a/fs/unionfs/dirhelper.c b/fs/unionfs/dirhelper.c
    index 2e52fc3..b40090a 100644
    --- a/fs/unionfs/dirhelper.c
    +++ b/fs/unionfs/dirhelper.c
    @@ -110,7 +110,6 @@ int delete_whiteouts(struct dentry *dentry, int bindex,
    lower_dir = lower_dir_dentry->d_inode;
    BUG_ON(!S_ISDIR(lower_dir->i_mode));

    - mutex_lock(&lower_dir->i_mutex);
    if (!permission(lower_dir, MAY_WRITE | MAY_EXEC, NULL)) {
    err = do_delete_whiteouts(dentry, bindex, namelist);
    } else {
    @@ -120,7 +119,6 @@ int delete_whiteouts(struct dentry *dentry, int bindex,
    run_sioq(__delete_whiteouts, &args);
    err = args.err;
    }
    - mutex_unlock(&lower_dir->i_mutex);

    out:
    return err;
    --
    1.5.2.2


    \
     
     \ /
      Last update: 2007-12-28 21:53    [W:0.020 / U:91.116 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site