Messages in this thread |  | | | Date | Wed, 26 Dec 2007 09:24:10 -0500 (EST) | | From | Steven Rostedt <> | | Subject | Re: [PATCH 02/16] adapt lguest launcher to per-cpuness |
| |
On Wed, 26 Dec 2007, Rusty Russell wrote:
> On Friday 21 December 2007 00:33:42 Glauber de Oliveira Costa wrote: > > + if (!vcpu_id) { > > + /* > > + * Service input, then unset the BREAK to > > + * release the Waker. > > + */ > > + handle_input(lguest_fd); > > + if (pwrite(lguest_fd, args, sizeof(args), 0) < 0) > > + err(1, "Resetting break"); > > + } > > I hate winged comments: those two extra lines, wasted! >
For multiple lines, wings are a Good Thing (TM). Otherwise it looks sloppy.
/* Service input, then unset the BREAK to * release the Waker. */ extra asterisk! ok then
/* Service input, then unset the BREAK to release the Waker. */ Yuck, that "release" looks like it can be code, especially with parsers that look for comments that start with some sort of /* or * Those little wings do IMHO make the code look nicer. I know in the Linux community, my weight compared to you is a chihuahua compared to a St. Bernard. But in this case, I believe others think that my collar is prettier than yours. ;-)
Some one buy Rusty a bigger hard-drive to store those extra lines.
-- Steve
|  |